I've researched learning/ behavioural science for well over a decade. I like the approach that you've outlined.
What you've described is building a habit of reflection - which is a proven approach to learn and develop, plus spaced learning, which is also a very proven approach.
The main point I'd call out is that rather than just thinking about 'spaced-repitition', its' better to think of 'spaced retrieval'. The retrieval is crucial, because it challenges illusions of competence (the distinction between recognising something and actually knowing it). Importantly, retrieval is not just about self testing, the 'retrieval' part might also involve sharing, application, and/or experimentation.
Finally, spaced retrieval tends to focus on memory/knowledge. That is different to building skills. For building skills you are best to adopt Deliberate Pratice techniques, ie. cycles of focused practice with 'expert' feedback to identify what good looks like.
